# used by munge function to safely interpolate # $1, $2 etc into the replacement string sub _safeswitch { my @P = (undef,$1,$2,$3,$4,$5,$6,$7,$8,$9); $_[0] =~ s/\$(\d)/$P[$1]/g; $_[0]; }

If I read the above correctly, it'll only handle 9 sets of capturing parens, and it's possible that we may have matched more than 9 sets.

My fix is to dynamically build @P to size.

# used by munge function to safely interpolate # $1, $2, etc. into the replacement string sub _safeswitch { my %seen; @seen{@+} = (undef) x @+; my @P; { no strict 'refs'; # allow $$_ to be $1, $2, etc. no warnings 'unitialized'; # allow undef as $$_ @P = map { $$_ } undef, 1 .. scalar keys %seen; } $_[0] =~ s/\$(\d+)/$P[$1]/g; $_[0]; }

And a test:

#!/usr/bin/perl use strict; use warnings; my $str = 'abcdefghijklmnopqrstuvwxyz'; my $pat = '(.).(.).(.)..(.).(.)(.)(.).(.)(.)(.).(.)(.)(.)(.).+'; my $repl = '$5$14$12$13 $1$8$9$13$4$3$11 $10$3$11$7 $4$1$2$6$3$11'; print munge( $str, $pat, $repl ), "\n"; sub munge { my($str, $pat, $repl) = @_; $str =~ s/$pat/_safeswitch($repl)/eg; return $str; } # used by munge function to safely interpolate # $1, $2, etc. into the replacement string sub _safeswitch { my %seen; @seen{@+} = (undef) x @+; my @P; { no strict 'refs'; # allow $$_ to be $1, $2, etc. no warnings 'uninitialized'; # allow undef as $$_ @P = map { $$_ } undef, 1 .. scalar keys %seen; } $_[0] =~ s/\$(\d+)/$P[$1]/g; $_[0]; } exit;
UPDATE

Incidentally, the line @seen{@+} = (undef) x @+; is a faster way to build
such a hash than the various equivalents ( %seen = map { $_ => undef } @+;
most notable among them for being popular and 4x slower).

I discovered this just today ;)

blyman
setenv EXINIT 'set noai ts=2'


In reply to Re: Re: Re: $1 in variable regex replacement string by belden
in thread $1 in variable regex replacement string by dvergin

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.