It's good to test your code. At least with -c.

Line 12: A reference is always defined. So the useful code will never be executed.
Line 18: There's a missing { and CGI won't pass under strict subs. And does a return value of undef make most sense?
Line 19: A { should be replaced with (.

Another thought: Wouldn't it be better to check for definedness for every subroutine instead of just the first? What if he decides to define another param subroutine and forget to remove param from @methods? Then the other subroutine won't get defined either. Of course, it would be a lot better to put it in a BEGIN block, as noted. Then you don't have to check for definedness manually, since perl will warn about redefinitions.

ihb

In reply to Re: Re: Importing CGI methods into a subclass as a class method by ihb
in thread Importing CGI methods into a subclass as a class method by Phaysis

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.