Hi. Seems the above replies have already solved your problem. But just a point of (hopefully) correction here. Do you have to keep explicitly using $_ ? Your code would be much more readable, you know, if you didn't do that. And use \s for your space, instead of a space character.
use strict; my $file = '.'; opendir(MYDIR,$file); my @files = readdir(MYDIR); foreach (@files) { next if( m/^\.+$/); if ( m/\s/g ) { my $oldfile = $_; s/\s/_/g; if (! -e) { rename $oldfile, $_; } else { print "Could not rename $oldfile because ${_} +name already exists and can not be overwritten\n"; } } print "$_\n"; }

In reply to Re: Checking for existing filename before renaming file by amrangaye
in thread Checking for existing filename before renaming file by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.