Note/Update: This was a response to dragonchilds reply, but I could not see the node. I apologize if this appears in the thread twice, but I didnt want it to get lost in the shuffle, so I moved it to a direct response 
# Your code
# Pure
sub walk_and_do
{
    my $self = shift;

    my $rc = 1;
    foreach my $child (@{$self->children})
    {
        $rc = $child->walk_and_do;
        last unless $rc;
    }

    unless ($rc)
    {
        $rc = $self->do_my_stuff;
    }

    return $rc;
}

# Same function, single return, just as clear (for me)
# ala TIMTOWTDI
sub walk_and_do {
   my($self,$flag,@return);
   
   $self = shift;

   for ( @{$self->childer} ) {
      (last && $flag = "$_->{err}") unless $_->walk_and_do;
   }

   if ($flag) {
      @return = ('0', "$flag");

   } else {
      @return = $self->do_my_stuff || ('0', $self->{err});
   }

   return(@return);
      
}# END sub walk_and_do

[download]
I don't want this to spiral downwards. What we are talking about here is PERSONAL style. For me its easier to maintain a single entry and single exit. Ill deviate when appropriate, but I tend to try and keep things straightforward. It makes it easier *for me* to maintain and extend my code.

/* And the Creator, against his better judgement, wrote man.c */

In reply to Re: A matter of style by l2kashe
in thread A matter of style by Ryszard

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.