No, I don't think we should. What is "good" coding and what isn't is very subjective. And that's also for what is a "red flag". Take for instance the first example. I do not agree that ($var1,$var2,$var3) = split is a red flag, let alone an obvious one.

Perlmonks is already too dogmatic IMO (for instance, all the chanting of "you didn't use 'strict' or 'warnings'" even for the smallest code fragments that wouldn't benefit at all from enabling strictness). I don't think a red flags area on Perlmonks would be a good thing.

Abigail, being kind fond of $& and friends.

In reply to Re: Should We Have A "Red Flags" Area? by Abigail-II
in thread Should We Have A "Red Flags" Area? by Cody Pendant

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.