Thank you all for your input. I hope it's been useful.

Thank you especially to extremely for pointing out the specific case that is a red flag, the $varN thing.

Also, what's a red flag anyway? A lot of you seemed to interpret it as "if you do this, you're a bad programmer" which is certainly not how I saw it at all.

To me a red flag is more like "that way works, sure, but did you know there's a much easier way?". Or in fact, it's maybe "that works, but you don't have to write code that way in Perl -- who told you you did?".

How about this example, to stimulate further discussion.

When I first started, the only way I knew how to iterate through an array was 

for ($x=0;$<@array;$x++){
  # .. do something with $array[$x]
}

[download]
but I would never do that any more. It looks horrible to me, plus, extra variables, more syntax to go wrong, scary for beginners and so on.

Is that a red flag? It shows either that the person's a refugee from another, less accomodating language, or it shows that they've learned from sources that don't understand how easy iterating through an array is in Perl.

Maybe it's just red flags for beginners that I'm interested in, er, flagging..?
--

“Every bit of code is either naturally related to the problem at hand, or else it's an accidental side effect of the fact that you happened to solve the problem using a digital computer.”
M-J D

In reply to Re: Should We Have A "Red Flags" Area? by Cody Pendant
in thread Should We Have A "Red Flags" Area? by Cody Pendant

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.