You can reduce the code quite a bit by playing to Perl's strengths. The quick way to load the story into an array (once you've opened the file) is
my @story = <FILE>;
You can reduce the amount of work you're doing to pull out bracketed words by doing
foreach my $line ( @story ) {
$line =~ s/\[([A-Za-z-]+)\]/Replace($1)/eg;
}
This replaces each bracketed work with whatever
Replace() returns for that word. The /eg modifiers on the regular expression say to replace whatever is found with the results of executing (/e) the expression on the right-hand side, and to repeat this match "globally" (/g) across the target string. And, because
$line is "aliased" to each row in
@story, you don't need to make a second pass through
@story.
Then, to print the story
print @story;
Now, you've localized all of the interesting work to
sub Replace {
my $word = shift;
...
}
which I'll leave as an exercise.
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.