I don't think there's anything inheriently wrong with what you describe, back in the day I had lots of "constructors" that were really "factories" (except that I wasn't doing dynamic Module loading ... they were all spelled out at the top).

I don't find myself writting code like that much anymore ... A big part of that has to do with the general code conventions of where I work now ... but even when I write code for personal projects, I don't think I would use the "Constructor is a Factory" approach -- mainly for clarity.

Ask yourself what (if anything) you gain by calling your factory method "new", and if it's worth the possible confusion of other people reading your code in the future.

In reply to Re: Constructor/Factory Orthodoxy by hossman
in thread Constructor/Factory Orthodoxy by mojotoad

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.