It's good that you have a working version now. There are some things you could improve, though:
- use strict;!!
- more flexibility through non-hard coded filenames
- error checking on opening files
- localising $_
- eliminate select statements
So an improved version of your sub would look like this:
sub indextime {
my ($infile, $outfile) = @_;
open my $in, '<', $infile or die "Couldn't open $infile for reading:
+ $!";
open my $out, '>', $outfile or die "Couldn't open $outfile for writi
+ng: $!";
my @matrix;
local $_;
push @matrix, [split] while <$in>;
my ($storenum, $date) = @{$matrix[0]}[0,1];
print $out "@{$matrix[$_]} $storenum $date\n"
for 6..$#matrix-1;
close $in or die $!;
close $out or die $!;
}
-- Hofmator
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.