The indentation in your code makes it a bit difficult to see what is in your foreach loops and what isn't. In addition to the problems with @pairs that jasonk and meetraz pointed out, there are some other things that don't make sense with the code pasted.

• You declare and assign to $base and $pair but never use them.
• In your last foreach you have $nn_pair as the loop variable, but use $_ inside the loop.
• At the top you say @pairs = get_nn_pairs (@segment1); but you are printing @sorted_array at the end of the sub, not returning the array.

You may want to try something like the code below:

sub get_nn_pairs {
    my @segment1 = @_;
    my @pairs;

    #  find and print all nn pairs form the sequence.

    foreach my $i (1 .. $#segment1) {
        push @pairs, "$segment1[$i-1]$segment1[$i]";
    }

    my %freq;
    foreach my $nn_pair (@pairs) {
        $freq{$nn_pair}++;
    }
    my @sorted_array = sort { $freq{$b} <=> $freq{$a} } keys %freq;
    return @sorted_array;
}


my @ordered_pairs = get_nn_pairs(@input);
[download]

---

---

Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!

Titles consisting of a single word are discouraged, and in most cases are disallowed outright.

Read Where should I post X? if you're not absolutely sure you're posting in the right place.

Please read these before you post! —

• How do I compose an effective node title?
• How do I post a question effectively?
• Markup in the Monastery

Posts may use any of the Perl Monks Approved HTML tags:

a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr

You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)

	For:		Use:
	&		&
	<		&lt;
	>		&gt;
	[		&#91;
	]		&#93;

Link using PerlMonks shortcuts! What shortcuts can I use for linking?

See Writeup Formatting Tips and other pages linked from there for more info.