Well, it seems as though everyone has thoroughly combed your code. As for the rest of your post on the other programmers' behavior...

*sigh* Your are the victim of human behavior at work. My suggestion. Make your suggestions and then leave it at that. Code up to your expectations and let them code up to theirs. It sounds like they are very similar to a rather large crowd of programmers I have met in the work place. They aren't excited about what they do, so they do enough to get by/collect a paycheck. ie. They won't learn object-oriented/abstracted/modular/efficient/etc... programming unless a project absolutely requires it. I believe Larry would call this false laziness.

Unless you're their boss, then all the rules are different.

In reply to Re: Bad Practice by petesmiley
in thread Bad Practice by mkirank

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.