Hi!

Actually you only need to do this: 

open(FILE1, $ARGV[0]) || die "Error: $!\n";
@lines = <FILE1>;

[download]
This evaluated <FILE1> in list-context, and thus the whole file will be put in the @lines-array, one entry per line (or whatever you have assigned to $/)

So then, why didn't your code work as you expected ? Well - the line 

@lines = $_;

[download]
assigns the variable $_ to the array @lines. You are declaring the contents of @lines each and every time through that loop. It's almost the same with variables: 
$foo = $_;

[download]
this also redeclares the contents of $foo every time it is evaluated. With scalars we usually use the . (dot) operator or string concat. operator to avoid redeclaring its content: 
$foo .= $_;

[download]
or: 
$foo = $foo . $_;

[download]
So, with arrays we have something similar: 
push @lines, $_;

[download]
That will add to @lines instead of redeclaring its contents.

Autark

In reply to RE: Parsing a file one line at a time by autark
in thread Parsing a file one line at a time by cburns

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.