Trivially eliminating the goto, I'd go with:

{
  ask('databasetype','Database type?','mysql');
    
  my $found; # aside: I hate " = undef"
  foreach $cur (@databases) {
    if (getConf('databasetype') eq $cur) {
      $found = 1;
      last;
    }
  }

  unless ($found) {
    output "Sorry, invalid option\n\n";
    redo;
  }
}
[download]

Next, I hate the artificial $found variable, so I'd merely move that into a subroutine:

{
  ask('databasetype','Database type?','mysql');

  unless (is_databasetype_valid()) {
    output "Sorry, invalid option\n\n";
    redo;
  }
}

sub is_databasetype_valid {
  foreach my $cur (@databases) {
    if (getConf('databasetype') eq $cur) {
      return 1;
    }
  }
  return 0;
}
[download]

That'd probably be enough, but that call to getConf seems to be perhaps invariant in that loop, so I'd pull it out to call the subroutine only once during the scan of @databases.

But hopefully, you get the idea now.

-- Randal L. Schwartz, Perl hacker
Be sure to read my standard disclaimer if this is a reply.

---

---

Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!

Titles consisting of a single word are discouraged, and in most cases are disallowed outright.

Read Where should I post X? if you're not absolutely sure you're posting in the right place.

Please read these before you post! —

• How do I compose an effective node title?
• How do I post a question effectively?
• Markup in the Monastery

Posts may use any of the Perl Monks Approved HTML tags:

a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr

You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)

	For:		Use:
	&		&
	<		&lt;
	>		&gt;
	[		&#91;
	]		&#93;

Link using PerlMonks shortcuts! What shortcuts can I use for linking?

See Writeup Formatting Tips and other pages linked from there for more info.