Yes it does appear that you have a race condition in that code. Since what you are doing is very similar to the needs of a read/write operation I'd suggest using a second lock file (called a semaphore file) to lock the whole operation between testing the existance of PID_LOCK and finally writing $$ to the file. Eg. 
sub single_instance{
    $SIG{INT} = sub {exit()};
    my ($prog) = $0 =~ m|(?:.*[/\\])?(.*)$|;
    my $tmp_dir = $^O =~ "MSWin32" ? "C:/Windows/Temp" : "/tmp";
    my $lockfile = "$tmp_dir/$prog.pid"; 
    local *PID_FILE; 
    open(SLOCK,">$tmp_dir/$prog.slock") or die("single_instance(): Can
+'t open slock: $!\n");
    flock(SLOCK,2);
    if (-e $lockfile){ 
        open(PID_FILE, "<$lockfile") or die("single_instance(): Can't 
+open $lockfile: $!\n"); 
        my $running_pid = <PID_FILE>; 
        close(PID_FILE); 
        chomp($running_pid); 
        if (kill 0, $running_pid){ 
            die("Already running as pid $running_pid\n"); 
            } 
        } 
    open(PID_FILE, "+>$lockfile") or die("single_instance(): Can't ope
+n $lockfile: $!\n"); 
    print PID_FILE "$$\n"; 
    close(PID_FILE); 
    close(SLOCK);
    chmod(0666, $lockfile);
    eval "END {unlink '$lockfile'}"; 
    die("single_instance(): $@\n") if($@); 
    }

[download]

This avoids the race condition because whichever process that first gets exclusive lock on the semephore file is able to read and write to the lock file before the other process can even test for the lock file's existance.

-caedes

In reply to Re: Determine if script is already running by caedes
in thread Determine if script is already running by Nitrox

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.