I'm embarassed to admit how long I've been writing Perl, and had never caught on to this little pitfall:
my $a = 1 and 0;
Since the
and operator has lower precedence than
=, this sets
$a to "1". Apparently no warning is issued, either.
In my defense, the actual code in which this came to light was a bit more complex:
my $can_remote =
defined($cfg->remote) and
(($cfg->get('remote') eq 'all') or
grep($type eq $_, split(/\s+|,\s*/,$cfg->get('remote'))));
Of course, changing
and to
&& solves the problem. However, now I'm faced with a big problem: How do I scan 100,000 lines of Perl in our application code base to look for other places where I've done this?!?
| -- |
| Jeff Boes |
| Database Engineer |
| Nexcerpt, Inc. |
|
|
|
...Nexcerpt...Connecting People With Expertise
|
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.