I don't see where the semaphore is set to any actual file. It seems like two different logger objects logging to the same log file would have two different semaphores and so defeat the purpose of locking anything. Wouldn't it be simpler to just lock the log file itself? (Though I can see the need for a common semaphore file if logs are cycled and you want log times to be continuous between cycled log files). Also, I don't get the need for:
my $FH=*{$$self{FILEHANDLE}};

[download]
And another way to get rid of the open warning is with:
$self->{FILEHANDLE}->open(">>$logfile") or ...

[download]
Update: Ah, just noticed the package $SEM variable. Nevermind on the first issue...(though you are assuming that all logging processes are in the same current directory opening the same semaphore file, maybe there ought to be a semaphore directory argument, or default to the same directory as the logfile, or ???).

In reply to Re: File locking with semaphores by runrig
in thread File locking with semaphores by TStanley

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.