You've solved a non-trivial problem in a trivial fashion. That's bound to cause problems. Running a blind sed on your
perl code is inadvisable, to say the least. There's no way
for either of your examples to *not* make an inappropriate
change in comments, pod, or any string that happens to
contain 'and':
sub sandbox {
my ($this, $that) = @_;
blarf($this) and mungle($that);
# etc.
}
Both of your examples will re-write that as:
sub s&&box {
my ($this, $that) = @_;
blarf($this) && mungle($that);
# etc.
}
Plus, there might be other programmers working on the project
that don't have this
and and
&& confusion.
As you've already realized, there's no quick fix for the OP. Either examine each file, or put a bit more time into writing a smarter parser.
I did ++ you for having one saving grace: re-writing the code to temp files rather than over the original code, and keeping the original stuff around.
I know that this is stuff you already realized - but there's a few other replies similar to yours, and I happened to choose yours to reply to :)
blyman
setenv EXINIT 'set noai ts=2'
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.