If I may be so bold as to suggest that you check out one of my modules, HTML::TokeParser::Simple. I am looking at the following and I think you can make it clearer:

  my $tag   = @{$tagstruct}[0];
  if ($tag =~ m!/!)
  {
    #print "endtag";
    next;
  }
  my %attrhash= %{@{$tagstruct}[1]};
  my @attrarr = @{@{$tagstruct}[2]};

[download]

With the "simple" version of TokeParser, the array structure remains exactly the same. This ensures that you can use the same interface, but gradually upgrade to something more legible:

  if ($tagstruct->is_end_tag)
  {
    #print "endtag";
    next;
  }
  my %attrhash= %{$tagstruct->return_attr};
  my @attrarr = @{$tagstruct->return_attrseq};

[download]

I am a big fan of self-documenting code and with this module, you no longer have to try and memorize array indices.

Cheers,
Ovid

New address of my CGI Course.
Silence is Evil (feel free to copy and distribute widely - note copyright text)

In reply to Re: code review for a WebTest Plugin module. by Ovid
in thread code review for a WebTest Plugin module. by efanche

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.