Briefly looking at your code, I would try removing all the \$ and $$ stuff and I think it will be a good start.
Use the return( $width, $height ); and get rid of the other one. Then in the main script you test like so.
if($height > 150 )
{ # ...
}
elsif($width > 150)
{ # ... stuff here
}
# ... more stuff here
In this program you dont need any references just the regular values $var etc.
Update: You might also try scaling the images by the same percent instead of by the same numeric amount. Say its 200x100 then 150/200 is .75 so make the 100 dimension 75 (100*.75) instead of 50 (100-(200-150)) like the current code would.
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.