If you use the 3rd arg to split, you shouldn't need to worry about recombining the line. Also, your code doesn't print anything to OUTFILE, it always prints to STDOUT. 

#!/usr/bin/perl 

while ($line = <>){
    my ($file, $record) = split /\|/, $line, 2;
    if ( open(OUTFILE, ">>$file") ) {
        print OUTFILE $record;
    }
    else { 
        die("cannot open $record[0]");
    }

}

[download]

Some stylistic tips: You can use the -n switch to perl to get an implicit while(<>){} loop around your code, and you can use the short-cut nature of or to simplify your conditional: 

#!/usr/bin/perl -n

my ($file, $rec) = split /\|/, $_, 2;

# Good idea, jdporter and BrowserUk
unless(exists $fh{$file}) {
  open $fh{$file}, ">> $file" or die "Can't open $file for append: $!\
+n";
}

$fh{$file}->print $rec;

[download]

Or, as a one-liner:

perl -ne '($f,$r) = split /\|/, $_, 2; exists $fh{$f} or open $fh, ">> $f" or die "Can't open $f for append: $!\n"; print $fh{$f} $r;'

Update: I liked jdporter and BrowserUk's idea about caching the filehandles, so I added it. :)

bbfu
Black flowers blossom
Fearless on my breath

In reply to Re: $" seems not to be working by bbfu
in thread $" seems not to be working by azool

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.