I'm curious to see what my fellow monks think of this piece of code for searching and replacing a line in a file. It works like I want it too but I'm wondering how many different ways there are to do this and how bad my code is.. Any advise would be greatly appreciated. 
#!/usr/bin/perl -w
#
# simple search and replace script -
# for a snort rule
#

use strict;

my $policy_file = "/usr/local/snort/rules/rules-new/policy.rules";

open(FILE,"$policy_file");

my @old_policy = <FILE>;

close(FILE);

open(FILE,">$policy_file");

for (@old_policy)
{
 if (/^alert ip 63.251/)
 {
  $_ = "#$_";
 }
print FILE $_;
}

close(FILE);

[download]
Thanks,

--JD

In reply to Simple Search and Replace? by draper7

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.