I'm wondering if 'last' is redundant if the call to the subroutine msg includes an 'exit'.
It is indeed redundant as it will never be reached, and I wouldn't be surprised if it was optimised out (see. Aristotle's reply on why this can't be done). It could be seen as self-documenting code, but it could be somewhat misleading and msg() should be documented denoting the fact that it exit()s when called. In fact, it looks a little like die(), so you might just want to use that instead e.g 
foreach (@array) {
   die "Yes, key found\n"
     if /key/;
}

[download]

HTH

_________
broquaint

update: extraneous semi-colon encountered a Backspace

In reply to Re: Is 'last' redundant? by broquaint
in thread Is 'last' redundant in this code? by kiat

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.