Please use \S+ instead of .*? so that backtracking won't waste CPU time. Please include \s after ($DEST_PORT) so that you won't match just a prefix of the destination port number.

I'd add to the above what perlguy recommended:

my %r= ( source_addr => '\S+', dest_addr => '\S+', proto => '\S+', source_port => '\d+', dest_port => '\d+', ); for my $param ( keys %r ) { my $value= $cgi->param($param) || ""; if( $value =~ s/^!\s*// ) { $r{$param}= "(?!\Q$value\E\s)($r{$param})"; } elsif( $value =~ /\S/ ) { $r{$param}= "(\Q$value\E)"; } else { $r{$param}= "($r{$param})"; } } my $regex= qr/ ^ \d+\s+ (\d+)\s+ $r{source_addr}\s+ ->\s+ $r{$dest_addr}\s+ $r{$proto}\s+ $r{$source_port} \s+>\s+ $r{$dest_port}\s+ /x; while( my $pkt= <DATA> ) { print $pkt if $pkt =~ $regex; }

                - tye

In reply to Re^2: Runtime Regexp Generation (! .*?) by tye
in thread Runtime Regexp Generation by tekkie

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.