A micro op that may save you time is to anchor your regex.. Which may or may not be possible.. I was thinking something along the line of say
.. snip ..
if (/^hostname ([-\w]+) /)
or
if (/^(?:\s+|)hostname ([-\w]+) /)
or even better if its on a line all by itself as you can at either end of the string..
I know its not why you asked, but you arent testing to see whether or not your open was successful..
# old line
open F, $path;
# new line IMHO
open(F, "$path") || die "Cant open $path: $!\n";
# or even
open(F, "$path")
|| ( print "Cant open $path: $!\n" && next);
# another small trim would be to do away with the interim
# array and filename..
$filelist = "/var/adm/links/newrun/filelist";
for ( `cat $filelist` ) {
chomp;
open(F, "$_") || die "Cant open $_: $!\n";
while (<F>) {
# anchor could apply here as well..
!/hostname/ ? next : chomp;
# work on hostname lines here
last;
}
close(F);
print $hostname. " ";
}
Just some rambling thoughts on the code..
MMMMM... Chocolaty Perl Goodness.....
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.