The big performance killer is searching your entire set of drives twice.

Search through the drives once and pop the names on to 2 arrays. Then go and perform your modifications.

Also index is quicker than a regex.

Quick hack and untested: 

my @rename_files;
my @modify_files;

finddepth (\&get_filenames , @fixedDrives );

sub get_filenames
{  
    push(@rename_files,$File::Find::name) 
       if( index($File::Find::name,$old_hostname) + 1 ); #index should
+ be quicker
    push(@modfy_files,$File::Find::name) 
       if ( -T $File::Find::name );  # -T is the same as -f and ! -B
                                                   
  }

[download]


grep
Mynd you, mønk bites Kan be pretti nasti...

In reply to Re: Search and update scripts by grep
in thread Search and update scripts by kirk123

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.