Hi All!

I have created a Perl script which connects to MySQL and fetchs data, the script is large and has many many instances of the section of code below: 
    my $sql = "SELECT * from shop_items";
    my $sth   = $dbh->prepare($sql);
       $sth->execute;
    while (my $hash_ref = $sth->fetchrow_hashref)
      {
             # bla bla bla
      }

[download]

I'm trying to come up with a way of reducing that to just one line, maybe by using a subroutine but Im not sure how, my thinking is along the lines of: 
   
   while(my $hash_ref = fetch_data("SELECT * FROM shop_items")) 
     {
           # bla bla bla
     }

  # SUBROUTINE FOR ALL CALLS

  sub fetch_data 
     {
           my $sql = @_;
           my $sth   = $dbh->prepare($sql);
              $sth->execute;
     }

[download]
I'm sure that's not quite right, but you get the drift of my thinking. Is this a good way to get rid of all those sections?

Thanks

In reply to Clean Up MySQL Code by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.