Here's a slightly different approach - I create a load of SQL statements, put them in an array,

foreach my $sql (@sql) {
       unless ($sth=run_sql($sql)){
            die "Failed in processing \"".$sql."\"\n";
    }
}
#Use them like this...
my $result = $sth->fetchall_arrayref;

[download]

and then run them using this subroutine - 

#
#run_sql
# subroutine that does all of the work
#
sub run_sql{
my $sql = shift;

    my $sth = $dbh->prepare($sql);
      if (!$sth) {
          die "Error:" . $dbh->errstr ." while preparing ".$sql."\n";
      }

      if (!$sth->execute) {
          die "Error:" . $sth->errstr ." while executing ".$sql."\n";
      }

return $sth;
} # run_sql

[download]

The idea here is that I like to pass statement handles around ($sth), which I can then do whatever I want with. I find this much more flexible than passing result sets around. YMMV!

Happpy Easter,

--
Anthony Staines

In reply to Re: Clean Up MySQL Code by astaines
in thread Clean Up MySQL Code by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.