Hi Peeps,

I have wrote the following code, it works, but it is laim coding. Would someone show me a better way of writing this (or parts of this) script.

#!/usr/bin/perl

use IO::Socket::INET;
$time   = localtime;
$users  = grep{ -d $_ } glob('/home/*');
$users = $users + 600;

$mx1pop3 = IO::Socket::INET->new(
  Timeout  => 1,
  PeerAddr => 'mail.test.com',
  PeerPort => 110,
  Proto    => 'tcp');

$mx1smtp = IO::Socket::INET->new(
  Timeout  => 1,
  PeerAddr => 'mail.test.com',
  PeerPort => 25,
  Proto    => 'tcp');

$mx1web = IO::Socket::INET->new(
  Timeout  => 1,
  PeerAddr => 'test.com',
  PeerPort => 80,
  Proto    => 'tcp');

$mx1dns = IO::Socket::INET->new(
  Timeout  => 1,
  PeerAddr => 'test.com',
  PeerPort => 53,
  Proto    => 'tcp');


if ($mx1pop3 and $mx1smtp) {
    $mail = 'Up';
} else {
    $mail = 'Down';
}

if ($mx1web) {
    $web = 'Up';
} else {
    $web = 'Down';
}

if ($mx1dns) {
    $dns = 'Up';
} else {
    $dns = 'Down';
}

print "Content-type: text/html\n\n";
print "<p><font size=1 face=Arial, Helvetica, sans-serif>$time</font><
+/p>\n" ;
print "<p><font size=1 face=Arial, Helvetica, sans-serif>Mail Servers:
+ $mail<br>Web Servers: $web<br>DNS Servers: $dns</font></p>\n" ;
print "<p><font size=1 face=Arial, Helvetica, sans-serif>Active Users:
+ $users</font></p>\n" ;

[download]

In reply to My Code Is Functional...But Not Tidy :( by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.