First a tiny nit. substr('p',0,1); is better written as 'p' ;-)

Next there is a potential problem. Your code works correctly only if the AM/PM is the last thing in the string. This may seem to be an unimportant restriction, but imagine the format was 'YYYY/MM/DD hh:mm pp|DD.MM.YYYY hh:mm pp'. In this case the indexes in @order will be incorrect!

The solution is to process the 'pp' at the same time as the other characters: 

use strict;
sub prepareFormat {
    my $format = shift;

    # TODO: check that only valid characters appear in the format
    # The logic should be: for any character A-Z in the format string,
    #   die if it's not one of: Y M D h m s p

    my ($i, @order) = 0;
    my $num_chars  = 'YMDhms';
    $format =~ s{([$num_chars]+|pp)(\?)?}{
        $order[$i++] = substr($1,0,1);
        if ($1 eq 'pp') {
            "(AM|PM|am|pm)"
        } else {
            '('.('\d' x length($1))."$2)"
        }
    }ge;

    $format = qr/^(?:$format)$/;
    return [$format, \@order];
}

sub parseDate {
    my ($format, $date) = @_;
    my @data = ($date =~ $format->[0])
        or return;
    my %result;
    for(my $i = 0; $i <= $#data; $i++) {
        $result{$format->[1]->[$i]} ||= $data[$i];
    }

    $result{h} += 12 if (uc($result{p}) eq 'PM' and $result{h} != 12);
    $result{h} = 0   if (uc($result{p}) eq 'AM' and $result{h} == 12);


    return map $result{$_}, qw(Y M D h m s);
}
...

[download]

Jenda
Always code as if the guy who ends up maintaining your code will be a violent psychopath who knows where you live.
   -- Rick Osborne

Edit by castaway: Closed small tag in signature

In reply to Re: Re: Re: date format string -> Reg Ex solution by Jenda
in thread date format string -> Reg Ex solution by markjugg

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.