I was looking for code to print all the combinations of a set taken two at a time. Looking here, I found code to print all the permutations of a list. I took that, bent it to my will, and came up with what's below.

It works as I want, I am just wondering if this could be done better or more efficently.
--SparkeyG 

#!/usr/bin/perl

my @list = (1 .. 5);
my $take = 2;

comb(\@list, $take, []);

sub comb {
    my @items = @{ $_[0] };
    my $group = $_[1];
    my @list  = @{ $_[2] };

    unless ($group) {
        print "@list\n";
    } else {
        my (@newitems,@newlist,$i);
        foreach $i (0 .. $#items) {
                @newlist = @list;
                push (@newlist, shift (@items));
                @newitems = @items;
                comb([@newitems], $group - 1, [@newlist]);
        }
    }
}

[download]

In reply to Printing combinations, code review request by SparkeyG

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.