Besides your problem (which, as Abigail-II notes, is not apparent from the piece of code you posted), that is a horrible construct - flag variables like $errorcount are a red flag, as are collections of $foo_bar, $foo_baz, $foo_quux variables. An initial cleanup leads to:
sub print_error { my $message = shift; print "<br><font color='red'>$message</font>"; # etc.. } unless($title and $url and $description and $keywords) { $title or print_error "Please enter a title."; $url or print_error "Please enter a valid address."; $description or print_error "Please enter a description."; $keywords or print_error "Please enter some keywords."; # ... }

You could still do a lot better if $title, $url etc where all stored in a hash. See Mark-Jason Dominus' excellent Program Repair Shop and Red Flags article series on Perl.com.

Update: thanks to The Mad Hatter for catching a small mishap. (s/$shift/\$message/)

Makeshifts last the longest.


In reply to Re: Constant variables by Aristotle
in thread Constant variables by esoteric neonate

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.