Well, personally, I would just put it under DBIx::Transaction. It's just a syntactic sugar module, and doesn't actually implement any kind of transactions. Calling it Transactions could be misleading to people.

I'm open to suggestions, but not to DBIx::. This module has a much wider scope. Currently, I know of no other modules that use begin_work, rollback and commit, but in theory any transaction capable module could be used with this.

This sample code doesn't actually work, does it? The use transactions part would be executed at compile time before $dbh has a value.

That's correct. I tested without a database, and was lazy so I supplied a string literal. I thought it was possible to reference the container instead of the value, but I was wrong. No, the module doesn't work.

If you only pass in $dbh at compile time (because it's done with a use), the $dbh inside transactions will never get updated.

That will have to be changed.

Defining your subs inline like that looks pretty strange.

That's because they're closures that share the same $dbh. Kind of useless if you consider that $dbh is a reference to undef, but I didn't know that at that time.

I don't think you need to take a reference to $_1, since it is a ref already.

That was because it was used in other subs, which have @_'s of their own. Needed to reference to avoid copying.

Creating a routine that takes sub refs but does not appear to (like transaction()) leads to many scoping bugs.

I will document that. Sourcefilters are an ugly solution. I'd rather introduce one very obvious bug than lots of subtle parsing bugs.

Maybe I'll make the module OO after all, but I think this looks ugly:

my $t = Transaction->new($dbh);
$t->transaction(sub {
    for (1..10) {
        my $sth = $dbh->prepare(...);
        $sth->execute() or $t->rollback;
    }
});
[download]

Or I can just have a function called transaction_select (lots of typing - better names welcome)

transaction_select $dbh;
transaction {
    for (1..10) {
        my $sth = $dbh->prepare(...);
        $sth->execute() or rollback;
    }
};
[download]

One thing's for sure: the module as pasted in this thread's root node does not work and needs to be fixed. Thanks for pointing that out.

Update: new version, with working code. I thought the OO solution was way too ugly and I didn't like transaction_select either. I decided to use a package global $T instead.

Juerd # { site => 'juerd.nl', plp_site => 'plp.juerd.nl', do_not_use => 'spamtrap' }

---

---

Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!

Titles consisting of a single word are discouraged, and in most cases are disallowed outright.

Read Where should I post X? if you're not absolutely sure you're posting in the right place.

Please read these before you post! —

• How do I compose an effective node title?
• How do I post a question effectively?
• Markup in the Monastery

Posts may use any of the Perl Monks Approved HTML tags:

a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr

You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)

	For:		Use:
	&		&
	<		&lt;
	>		&gt;
	[		&#91;
	]		&#93;

Link using PerlMonks shortcuts! What shortcuts can I use for linking?

See Writeup Formatting Tips and other pages linked from there for more info.