I haven't tested this but believe it is cleaner to write as

sub commit () {
    ($T || ${ caller() . '::T' })->commit;
    goto END_XACTION;
}

sub rollback () {
    ($T || ${ caller() . '::T' })->rollback;
    goto END_XACTION;
}

sub transaction (&) {
    my ($block) = @_;
    local $T = ${ caller() . '::T' } or croak "\$T not set";

    local $@;
    eval {
        $T->begin_work;
        $block->();
    };
    $@ ? rollback : commit;

    END_XACTION: die $@ . "commit not safe after errors, transaction r
+olled back"
        if $@;
}
[download]

I would suggest you work with die instead though - that will work with nested transactions and require fewer hoop jumps. You can then also easily add some more error checking:

sub commit {
    require Carp;
    Carp::croak("Can't commit outside a transaction");
}

sub rollback {
    require Carp;
    Carp::croak("Can't rollback outside a transaction");
}


sub transaction (&) {
    my ($block) = @_;

    my $caller = caller();

    local *{"${caller}::commit"} = sub { die "!COMMIT\n" };
    local *{"${caller}::rollback"} = sub { die "!ROLLBACK\n" };

    local $@;
    eval {
        $T->begin_work;
        $block->();
    };

    if(!$@ or $@ eq "!COMMIT\n") {
        ${"${caller}::T"}->commit;
    }
    elsif($@ eq "!ROLLBACK\n") {
        ${"${caller}::T"}->rollback;
    }
    else {
        ${"${caller}::T"}->rollback;

        require Carp;
        Carp::croak($@ . "commit not safe after errors, transaction ro
+lled back");
    }
}
[download]

Makeshifts last the longest.

---

---

Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!

Titles consisting of a single word are discouraged, and in most cases are disallowed outright.

Read Where should I post X? if you're not absolutely sure you're posting in the right place.

Please read these before you post! —

• How do I compose an effective node title?
• How do I post a question effectively?
• Markup in the Monastery

Posts may use any of the Perl Monks Approved HTML tags:

a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr

You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)

	For:		Use:
	&		&
	<		&lt;
	>		&gt;
	[		&#91;
	]		&#93;

Link using PerlMonks shortcuts! What shortcuts can I use for linking?

See Writeup Formatting Tips and other pages linked from there for more info.