Death to Dot Star is a good read.

your regex is capturing to much to fast. This is better:

#!/usr/bin/perl -w
use strict;
use warnings;

my $default_from_domain = 'www.domain.com';
my $unsub = 'un-foo@foo.com un-foo@foo.com';
print $unsub, "\n";

$unsub =~ s/(un-[^\@]+)\@[^ ]+/$1\@$default_from_domain/g ;
print $unsub;

[download]
update:
Assuming the optimizer did not exist your regex would capture as follows (not sure how the optimizer optimizes so I am going to pretend it is not there): the (un-.*) would capture from the first place it sees un- in your string and then the .* makes it capture from this point on. It will then try to match the next thing in your regex which in your case is \@ it will thus backtrack until it finds one. At this point you have "un-foo@foo.com un-foo@" matching. The little engine that could then moves on and tries to match the next thing. Which is again .* which will of course capture the rest of the string.

So far you have the following then: $1 contains "un-foo@foo.com un-foo" and $2 contains "foo.com". Anyhow since it captures the whole string right of the bat it will not find another match.

-enlil

In reply to Re: regex search and replace globally by Enlil
in thread regex search and replace globally by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.