By visual inspection I can see a number of errors.
use strict is lacking a semicolon. If you mean to use strictures then you must predeclare all your variables as either package variables (with use vars) or lexical variables (with my).
There is a big conceptual problem with calling localtime repeatedly. What happens if you make the individual calls at the exact moment when the minute, hour, day... wraps around? Instead of getting 4:59:59, you might wind up with 5:00:59. localtime will return an array. Call it once and save the result as an array and then pick out what you want, rather than calling it repeatedly and carving out what you want with array slices.
To zero fill a value, as you do for the minutes, it's much simpler to write $min = sprintf('%02d', $min). Saying $min = $min is what's known as a nop.
Other than that, you're off to a good start. Keep it up, and read as much code by other people as you can.
____________________________________________________________
Join the monks coming to YAPC::Europe 2003 in Paris, 23-25 July 2003.
In reply to Re: Simple Greeter (well, it's a start)
by grinder
in thread Simple Greeter
by harley_frog
| For: | Use: | ||
| & | & | ||
| < | < | ||
| > | > | ||
| [ | [ | ||
| ] | ] |