Other posts have given you code to do what you need, here is why your code fails.
Consider an array that has the following: 
    my @array = ("", "");

[download]
Now hand trace the part of clean() that splices out the blank elements.

the loop will iterate from 0 to 1
Element 0 gets spliced out, leaving the array with the singile element at index 0 = ""
and your loop iterator gets incremented to 1, but the blank element that was at position 1 is now at position 0 as a result of the splice. That element never gets a chance to be examined.

To summarize, splice()ing out array elements changes the indexes of subsequent elements, so your loop iterator wont indicate whta it was intended to.
As a "band-aid" to your function, if you change the unless() action as follows: 
    splice @clean, $i, 1;
    $i--;

[download]
your function should work as you want it to.

But, others have offered better solutions.

In reply to Re: Array Cleaning by shemp
in thread Array Cleaning by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.