A few main points I'd change.

The name of the module and the hardcoded URI data could and should be generalized. The URI data might be part of the cconstructor arguments, or it could be loaded from a configuration file. That would allow reuse by many sites.

Second, you have commented out initializations for 'our @ISA' and others. Don't use our for that. @ISA, @EXPORT, @EXPORT_OK, etc. are package globals. Declare with use vars qw( @ISA @EXPORT @EXPORT_OK ); to keep strict happy.

In the line open DOMAINS, ">Domains.txt" or die #...;, you should use the 3-arg open since you require 5.6.0 anyway, and the 'Domains.txt' should be an absolute path taken from configuration, like the URI data. Remember that a module has even less control than a script over the current directory. Relative paths are made bad things by that.

It would have been good to post the code directly, between readmore tags. Your links may not always resolve.

After Compline,
Zaxo

In reply to Re: My first module. I can't find any problems with it! by Zaxo
in thread Code review request for my first module - WWW::PostiniAdmin by afresh1

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.