I don't know if this works - away from my trusty Linuxbox - but it is a good idea. A pure perl
Archive::Zip would be a really _brilliant_ idea - great for app packaging.
A few comments just from reading the source:
- It's a good idea to stick to one subroutine naming convention: like_this or likeThis. In Perl, like_this is preferred as more readable.
- You have an OO interface, so why export functions (esp. automatically)? AFAICS Archive::Tar doesn't do this.
- ... especially as you are exporting functions named the same as Perl core functions (e.g. "read")
- Hmm... do you come from Java? I don't see anything wrong with using $this instead of $self, it is just a bit unusual.
- int $verbose == 0: no need. Just and not $verbose would be fine.
- Similarly, return unless fileno $filehandle; is fine, and avoids non-standard brackets.
I'm just looking for nitpicks, you understand. It seems like very nice, clear code.
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.