Well, the main problem I see is that you are using
x instead of
* for multiplication.
x is the string repeat operator. For example
print 3 x 4; # This prints "3333"
print 3 * 4; # This prints 12
Added Here is a fixed and cleaned up version of your code:
#!/usr/bin/perl -w
use strict;
use Regexp::Common;
my $a = prompt("A? = ");
my $b = prompt("B? = ");
my $c = prompt("C? = ");
my $root = sqrt(($b**2) - 4 * $a * $c) / (2 * $a);
my $ans1 = -$b + $root;
my $ans2 = -$b - $root;
print "Answers: $ans1 AND $ans2\n\n";
sub prompt {
my $var;
do {
print $_[0];
$var = <STDIN>;
chomp $var;
} while ($var !~ /\A$RE{num}{real}\z/);
return $var;
}
The major thing I added was the
prompt sub. It will prompt the user for a value, and if the value isn't a real number, it will continue to prompt them until they enter a real number.
And as for a more elegant way of making a number negative, simply do -$b.
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.