I think your lack of atomicity is going to get you into trouble, though if you have a low traffic environment it won't happen often, and when it does you'll be quite perplexed. The problem will be when one process (we'll call it "process A") makes an insert, then another process ("process B") makes an insert, and then process A checks the last insert ID, getting back the insert ID for process B's operation, and not its own. This may in fact never happen if your environment isn't being hammered on too heavily, but if it does happen, it will result in a bug that will be very hard to reproduce.

To be absolutely safe, you need either a database mechanism that both inserts and gets the insert ID atomically (you can do this with DBI as Bart suggests, but I don't know about your wrapper), or you need to generate your own insert ID randomly, try inserting into the table with it, and also do exception handling for the rare scenario of a collision, in which case you'll want to generate another id and try again.

In reply to Re: Getting last MySQL id with Class::DBI by awgibbs
in thread Getting last MySQL id with Class::DBI by broquaint

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.