Do you actually need to generate a grep command or is it okay to actually perform the search with Perl itself?

Also, there is no reason to do cat file | grep pattern, you can just do grep pattern file. There is a small difference if you are searching more than one file, since grep pattern file1 file2 shows the file names on the output, whereas cat file1 file2 | grep pattern does not.

Okay, if you really need to generate a grep command, I would do it like this:

#!perl -w use strict; my $starttim = 4; my $endtime = 9; my $pattern = "^(" . join("|", map { sprintf "%02d", $_ } $starttim .. $endtime ) . ")"; my $cmd = "grep -e '$pattern' file"; print "cmd = $cmd\n";
The join function is great when you need to have things between the elements of list. Much easier than coding a loop.

In reply to Re: Generating a grep command at run time by Thelonius
in thread Generating a grep command at run time by chimni

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.