Secondly wouldnt a grp pattern file be faster than reading the file line by line and pattern matching like this $_ =~ /^(04|05).

I doubt it. Grep has to read the entire file in, too, so you're not saving anything in disk access. There might be some speedup if grep on your system is implemented to read normally instead of line-by-line. Really, from a speed point of view, it will all come down to whichever program has a more optimized regex engine. In practice, the extra expense of just executing grep will probably make up for any lost speed.

Further, I wouldn't worry about speed at all. The pure-Perl soultion will work just fine. Relying on external programs like this is generally a Bad Thing (tm). There are many problems with using external programs, not the least of which is potential security issues. It also tends to make less maintainable code.

----
I wanted to explore how Perl's closures can be manipulated, and ended up creating an object system by accident.
-- Schemer

Note: All code is untested, unless otherwise stated


In reply to Re: Re: Generating a grep command at run time by hardburn
in thread Generating a grep command at run time by chimni

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.