I'll admit that it took me a while to figure out what these constructions were doing

$uid = ${$entry->get('uid')}[0] if defined $entry->get('uid'); # and $uids{$uid}{$_} = ${$entry->get($_)}[0] if defined $entry->get($_);

I think using a temporary var to hold the array reference is preferable to calling the function twice. It also simplifies and clarifies (IMO) the code.

for my $entry ( $searchresult->entries ) { my $aref = $entry->get( 'uid' ); my $uid = $aref->[0] if $aref; if( $uid ) { for ( @vars ) { $aref = $entry->get( $_ ); $uids{ $uid }{ $_ } = $aref->[0] if defined $aref; } } else { print "*** No uid for the following entry:\n"; print Dumper( \$entry ); } }

I have also come to prefer a little more whitespace inside parens, curlies and the like, but that a very personal thing.


Examine what is said, not who speaks.
"Efficiency is intelligent laziness." -David Dunham
"When I'm working on a problem, I never think about beauty. I think only how to solve the problem. But when I have finished, if the solution is not beautiful, I know it is wrong." -Richard Buckminster Fuller

In reply to Re: About BLOCK variables by BrowserUk
in thread About BLOCK variables by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.