Well, given the the array ref return by $entry->get(...), there's not much that can be done to simplify it further.

If you wanted to go for gold on Aristotles patented scale of Yukiness, you could reduce it somewhat more

for my $e ( $searchresult->entries ) { my ($r, $uid) = ($e->get('uid'), $r ? $r->[0] : ()); print "*** No uid for the following entry:\n" , Dumper \$e and next unless $uid; ($r, $uids{$uid}{$_}) = ($e->get($_), $r ? $r->[0] : '' ) for @var +s; }

I'll probably get drummed out of the PerlMonks Code-Scribes Guild for even joking about that......but then again, I was never invited to become a member, so what the hay:)

However, if its in your power to arrange for $entry->get(..) to return a list instead of an array reference, then the code gets much cleaner....

for my $entry ( $searchresult->entries ) { my ( $uid ) = $entry->get( 'uid' ); print "*** No uid for the following entry:\n" , Dumper \$entry and last unless $uid; ( $uids{$uid}{$_} ) = $entry->get($_) for @vars; }

which is much nicer I think, but can you change get()?

If you can, then it would be even better to have it use wantarray to test for the return context and only return the first value of the array (or undef or '') if called in a scalar context (as this seems to be all you want) and the whole array (or ()) in a list context. Then you can remove the parens around the assignments in the last example and it get a little cleaner still.

Note: Obviously none of the examples have been tested in context. I've checked individual bits, but...


Examine what is said, not who speaks.
"Efficiency is intelligent laziness." -David Dunham
"When I'm working on a problem, I never think about beauty. I think only how to solve the problem. But when I have finished, if the solution is not beautiful, I know it is wrong." -Richard Buckminster Fuller

In reply to Re: Re: Re: About BLOCK variables by BrowserUk
in thread About BLOCK variables by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.