Your example is fine. I would probably return a reference to a hash, but that shouldn't make a great deal of difference in your case. You should, however, try to eliminate the pointless copying of data after you fill %gnarf.

Why do @gak = @{$gnarf{gak_array}}; when the data is already available via $gnarf{gak_array}? It looks to me like you just need to get a little more comfortable with using references. If you are trying to cut down on some typing, copy the reference rather than the whole array; use my $gak = $gnarf{gak_array}; instead.

-sauoq
"My two cents aren't worth a dime.";

In reply to Re: Optimizing the use of hashes in subroutines by sauoq
in thread Optimizing the use of hashes in subroutines by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.