Personally, I can see very little point using a hash just to name the returns from a subroutine. What are you going to do with the names?

In the example you gave, all your doing is using them to unpack the hash into seperately named entities anyway, so don't. Pass back references for the arrays (or hashes) and assign them directly to the named references in the calling code.

The result is quicker, cleaner and more readable (IMO).

### Take in the string $val, produce some ### scalars and two arrays sub mysub { my $val = shift; my @foos = 0 .. rand(50); my @bars = 0 .. rand(50); return scalar @foos, # How many foos scalar @bars, # How many bars [sort @foos], # Assorted foos (no chilli) [sort @bars]; # Ditto bars (hic!) } my $val = 'Irrelevant'; my ($foo, $bar, $gak, $flub) = mysub($val); print "I have $foo foos: @{$gak}\n"; print "I have $bar bars: @{$flub}\n"; # That's "sheep" and "pub" when +I'm sober. print "The first foo is $gak->[0]\n"; print "The last bar is $flub->[-1]\n"; __DATA__ D:\Perl\test>junk I have 24 foos: 0 1 10 11 12 13 14 15 16 17 18 19 2 20 21 22 23 3 4 5 +6 7 8 9 I have 29 bars: 0 1 10 11 12 13 14 15 16 17 18 19 2 20 21 22 23 24 25 +26 27 28 3 4 5 6 7 8 9 The first foo is 0 The last bar is 9

A numeric sort would be more sensible for numeric data, but its only an example!


Examine what is said, not who speaks.
"Efficiency is intelligent laziness." -David Dunham
"When I'm working on a problem, I never think about beauty. I think only how to solve the problem. But when I have finished, if the solution is not beautiful, I know it is wrong." -Richard Buckminster Fuller

In reply to Re: Optimizing the use of hashes in subroutines by BrowserUk
in thread Optimizing the use of hashes in subroutines by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.