There is nothing wrong with open(FH, "> $file");

perldoc -f open says:

The filename passed to 2-argument (or 1-argument) form of open() will have leading and trailing whitespace deleted
I prefer to put some whitespace between the permissions operator and the filename, others do not. It's a style thing, but there is nothing wrong with it.

Preferably use warnings instead of perl -w. There is a thread here explaining why, but I can't track it down right now. See perldoc perllexwarn for more info.
You should consider using the strict pragma as well as the warnings pragma.

Another minor point - I personally find 

my $dir = $entry;
open(FILE, "> $dir") or die "Can't open file, $dir: $!";

[download]
slightly grating.
It's a file you want to create - I initially couldn't figure out if you really wanted opendir to open a directory handle, or if you wanted: 
my $file = $entry;
open(FILE, "> $file") or die "Can't open file, $file: $!";

[download]
It's little things like that which make maintenance programmers go insane :-)

As another poster has already pointed out, you can't go creating files, directories, pipes etc, in the same directory with the same name as an existing file/dir/pipe.

If the information in this post is inaccurate, or just plain wrong, don't just downvote - please post explaining what's wrong.
That way everyone learns.

In reply to Re: Re: Some problems with my code - Help... by BazB
in thread Some problems with my code - Help... by star7

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.