The problem of repeating all those pushes is not necessary. A nice data structure like a hash will settle that:

sub read_db_list { my %listdb; # ... in the read loop # replacing the if block push @{$listdb{ uc substr( $file_name, 0, 1) }}, $infoline; # after all is read return \%listdb; }
The %listdb hash automatically has as many keys as your files have initial characters. Those keys are created as needed by uppercasing the first character of the name, which is extracted by substr. By treating the hash value as an array reference, it automagically becomes one, giving you a hash of arrays - affectionately known as HoA.

To print all that you may want to look at one of the template modules, or else use CGI.pm's handy html generation functions. Those are very nifty with array references.

After Compline,
Zaxo


In reply to Re: Help to improving my code please? by Zaxo
in thread Help to improving my code please? by spacey

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":



  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.