Nothing wrong with your code - it gets the job done, it's easy to understand - it's not that big. "jeffa" had a good example using the perl "grep" function, but I find those long one or two liners harder to understand than something simple (with a few more lines) like you've done here.
As "jeffa" (I think) pointed out, you could probably shorten your code by replacing the prepare, execute, and fetch with a selectrow_arrayref - from 'perldoc DBI':
"selectrow_arrayref"
$ary_ref = $dbh->selectrow_arrayref($statement);
$ary_ref = $dbh->selectrow_arrayref($statement, \%attr);
$ary_ref = $dbh->selectrow_arrayref($statement, \%attr, @
+bind_values);
This utility method combines "prepare", "execute" and
"fetchrow_arrayref" into a single call. It returns the firs
+t row of
data from the statement. The $statement parameter can be a
+ previ-
ously prepared statement handle, in which case the "prepare
+" is
skipped.
+
If any method fails, and "RaiseError" is not set, "selectro
+w_array"
will return undef.
HTH.
Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
Read Where should I post X? if you're not absolutely sure you're posting in the right place.
Please read these before you post! —
Posts may use any of the Perl Monks Approved HTML tags:
- a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
| |
For: |
|
Use: |
| & | | & |
| < | | < |
| > | | > |
| [ | | [ |
| ] | | ] |
Link using PerlMonks shortcuts! What shortcuts can I use for linking?
See Writeup Formatting Tips and other pages linked from there for more info.