One option may be to move all the %mail declarations into an array-of-hash-references or a hash-of-hash references. Then, your if-elsif-else can be converted into a CASE or SWITCH type block which sets a reference to the hash you want to send to sendmail(). This will make your script a little easier to read and make it easier to add items to the CASE/SWITCH by adding more logic and additional entries into the hash.

OTOH, as someone once said: If it ain't baroque, don't fix it. Not to be facetious, but is this script having performance or resource problems? Security issues? Limited features? I understand the need for efficiency and I respect slick coding as much as the next monk, but unless you have a good reason, why modify something that you have been using for a year(in a production environment I assume) unless you want to expand it's functionality or correct a flaw? Just a thought.

Later

In reply to Re: Advise on current Mail script by pzbagel
in thread Advise on current Mail script by Anonymous Monk

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post, it's "PerlMonks-approved HTML":


  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, details, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, summary, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.